Emit 'connecting' event from PQ handshake #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matszczygiel
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
322a6b6 to
db6e3e7
Compare
matszczygiel
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
db6e3e7 to
33cf89d
Compare
matszczygiel
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
33cf89d to
af0152c
Compare
matszczygiel
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
af0152c to
0da9ad5
Compare
matszczygiel
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
0da9ad5 to
a7d82ca
Compare
matszczygiel
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
a7d82ca to
3087a62
Compare
Jauler
reviewed
Dec 3, 2024
LukasPukenis
reviewed
Dec 4, 2024
Jauler
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
8229ed0 to
6b8bcff
Compare
Jauler
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
6b8bcff to
9ff41f7
Compare
Jauler
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
9ff41f7 to
5592c18
Compare
Jauler
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
5592c18 to
a60d8bc
Compare
Signed-off-by: Mateusz Szczygieł <[email protected]>
Jauler
force-pushed
the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
from
a60d8bc to
74d027a
Compare
Every test using |
mathiaspeters
approved these changes
Dec 12, 2024
Jauler
deleted the
msz/LLT-5814-post-quantum-vpn-status-is-reported-only-after-post-quantum-handshake
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When issuing a PQ connection request, the node state was reported as 'CONNECTING' only when the PQ handshake was finished. This led to no state being reported when the handshake was failing.
Solution
Emit a 'CONNECTING' event upon PQ handshake
To Reviewers
The approach taken here is, to some extent, naive. But unfortunately there is some time pressure to fix the event emiting issue, due to a fact that integrators are, to some extent, blocked by the bug. Therefore fixing of the issue has been divided into two parts, one is implement - maybe not the most clean solution, but quick one to avoid unecessary development blockages. And then refactor this solution into better approach. The quick-and-dirty solution is being implemented in this PR, and the refactoring is being performed here: #1021.
☑️ Definition of Done checklist